fix: correct the family experience table and extend it to level 30 - #130
Conversation
Every row was wrong. Level 1 asked 100 000 against 80 000, level 7 asked 1 900 000 against 512 000, and the curve stopped at 19 where the game goes to 30. A family would have needed roughly triple the experience it should at the top of the old table and then been unable to level at all. From level 20 the requirement is the previous one plus a tenth, compounded unrounded and floored, which is why those rows are not round. Version bumped to 2.1.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 25 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
The table merged in #129 was wrong in every row, and short.
Two separate faults: the numbers, and the ceiling. A family reaching 19 on the old table would have hit
uint.MaxValueand been unable to level at all, because the game goes to 30.The
<remarks>in #129 already flagged the level 7 row as suspect off a singleginfoobservation. It was right to doubt it — the whole curve was off.From level 20 the requirement is the previous one plus a tenth, compounded on the unrounded value and floored —
20 000 000 × 1.1ⁿreproduces rows 20–30 exactly, including the non-round tail (47 158 953,51 874 849). That the derived formula lands on every published row is decent evidence the numbers are self-consistent rather than transcribed noise.Also adds
Constants.MaxFamilyLevel = 30alongside the other level ceilings, and extends the approval table to cover the full range.Version bumped to
2.1.0. 22/22 tests pass.🤖 Generated with Claude Code