FCOMBO triplets are read one field too early - #2290
Open
denislauri1999 wants to merge 2 commits into
Open
Conversation
The first field of an FCOMBO row is not a step, it is a switch: 1 when the
skill has a combo chain and 0 when it has not, which holds for all 1958 skills
in the file. Five triplets of (hit, animation, effect) follow it, and the
parser counted them from the switch instead of from after it.
220 Basic Slash FCOMBO 1 | 3 40 513 | 4 25 525 | 5 13 524 | 0 0 0 | 0 0 0
read as (hit 1, anim 3, eff 40), (hit 513, ...), (hit 525, ...)
Hit 513 never arrives - the consecutive-hit counter stays in single figures -
so the chain could not fire on any of the twenty-one skills that carry one.
Nothing reported it: no exception, just the third blow's special animation that
never plays.
Two tests. The first parses the real row above and asserts the three steps,
with a final check that no hit number reaches double figures - which is the
shape the bug had, and the shape any future off-by-one would have. The second
holds a skill with no chain to zero saved steps, so the switch cannot be
mistaken for a step again.
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Three lines for the offset, one for the test fixture. The rest was retelling what the assertions already check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first field of an
FCOMBOrow is not a step, it is a switch: 1 when the skill has a combo chain and 0 when it has not — true of all 1958 skills in the file. Five triplets of (hit, animation, effect) follow it, andAddComboscounted them from the switch instead of from after it.Hit 513 never arrives — the consecutive-hit counter stays in single figures — so the chain could not fire on any of the twenty-one skills that carry one. Nothing reported it: no exception, just the third blow’s special animation that never plays.
The raw row starts at index 2 (field 0 is empty, field 1 is the section name), so the switch sits at 2 and triplet j starts at
3 + j*3.Tests
Two. The first parses the real row above and asserts all three steps, ending with a check that no hit number reaches double figures — that is the shape this bug had, and the shape any future off-by-one would have. The second holds a skill with no chain to zero saved steps, so the switch cannot be mistaken for a step again.
Zero warnings, all tests pass.