The two BCard types the files do name - #2317
Conversation
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
32bf5f1 to
7c757c7
Compare
|
Rebased and trimmed to the CLAUDE.md that landed today: comments cut back to the ones that answer a question a reader would otherwise have to dig for, and nothing outside the project named. No behaviour change in this push. |
7c757c7 to
339413b
Compare
Types 93 and 94 keep a number while their names resolve in the client's own language files: 93 Changes the elemental percentage. 94 Changes the elemental resistance percentage. So they become ElementPercentage and ElementResistancePercentage, and their members follow. They are worth naming because they are the percentage halves of types 7 and 13, and the pairing is not by number: 93 follows 7's subtype order, where "all" is 51, while 94 follows 13's, where "all" is 11. A reader who sees two bare numbers has no way to know that; a reader who sees the names does. The types around them that keep a number keep it for a reason: their own name token resolves in none of the eight languages the client ships. Tested: builds with 0 warnings, full suite green, parser tests 104/104 with the opt-in category excluded. A rename only - nothing reads these yet.
339413b to
2ee65cc
Compare
denislauri1999
changed the title
2 participants
What
Types 93 and 94 keep a number while their names resolve in the client's own language files:
So they become
ElementPercentageandElementResistancePercentage, and their members follow.Why these two are worth naming
They are the percentage halves of types 7 and 13 — the same quantity declared in a second unit. And the pairing is not by number:
93 follows 7's subtype order and 94 follows 13's. A reader looking at two bare numbers has no way to know that; a reader looking at the names does.
Why the neighbours keep their numbers
The types around them keep a number for a reason worth stating: their own name token resolves in none of the eight languages the client ships. They are buckets by content epoch rather than by mechanic, so a name would describe at most half of what is inside.
Testing
NosCore.Parser.Testspasses 104/104 withTestCategory!=OPTIONAL-TEST.BCardEffectenum — the earlier version of this PR was written againstAdditionalTypes.csand no longer applied.