[18.0][MIG] edi_partner_oca: Migration to 18.0 #241
[18.0][MIG] edi_partner_oca: Migration to 18.0 #241Ricardoalso wants to merge 10 commits intoOCA:18.0from
Conversation
Ricardoalso
force-pushed
the
18.0-mig-edi_partner_oca_v2
branch
2 times, most recently
from
a6070f4 to
29f77db
Compare
|
This PR has the |
etobella
left a comment
etobella
left a comment
There was a problem hiding this comment.
IMO edi_endpoint_oca is not required. You are adding unnnecessary requiremnts, just for adding the mixin on partner, edi_core_oca is enough.
| "website": "https://github.com/OCA/edi-framework", | ||
| "depends": [ | ||
| "contacts", | ||
| "edi_endpoint_oca", |
There was a problem hiding this comment.
Indeed, it is not needed, and I have just replaced it with edi_core_oca.
If I remember correctly, I had some strange test failures in the CI back then.
The PR is now corrected with a fixup commit; let me know when it is OK with you and I will rebase.
Thanks @etobella
There was a problem hiding this comment.
Okay, the same error triggered in the CI and it seems linked to dependencies load order. I will investigate
There was a problem hiding this comment.
After some moving around, I moved origin_edi_endpoint_id out of the abstract edi.exchange.consumer.mixin extension and into concrete glue modules (edi_partner_endpoint_oca and edi_sale_endpoint), then removed the old edi_endpoint_oca mixin file. This avoids global field injection and fixes the registry load-order KeyError while keeping endpoint-origin fields available where needed.
I still need to do some cleaning and commit renaming + rebases. Can I let you check the new structure proposition ?
OCA-git-bot
added
series:18.0
mod:edi_partner_oca
Prevent form view traceback with missing fields edi_config + edi_has_form_config
…_oca and edi_endpoint_oca
It was created to fix the registry initialization error:
::
KeyError: 'Field edi_endpoint_id referenced in related field definition
res.partner.origin_edi_endpoint_id does not exist.'
By depending on both modules and using ``auto_install = True``, Odoo installs
this glue module only when both prerequisites are present, ensuring a safe
module loading order.
Ricardoalso
force-pushed
the
18.0-mig-edi_partner_oca_v2
branch
from
cf759d9 to
7abebda
Compare
OCA-git-bot
added
mod:edi_partner_endpoint_oca
…partner_oca and edi_endpoint_oca
Ricardoalso
force-pushed
the
18.0-mig-edi_partner_oca_v2
branch
from
fec8e25 to
6e6b952
Compare
7 participants
No description provided.