Repository navigation
[19.0][FIX] mail_tracking: retry failed emails without the removed resend wizard - #275
Open
alvaro-domatix wants to merge 1 commit into
Open
alvaro-domatix wants to merge 1 commit into
alvaro-domatix wants to merge 1 commit into
Conversation
…send wizard The Retry button of failed messages opened the action mail.mail_resend_message_action, which no longer exists in 19.0 (Odoo removed the resend wizards in odoo/odoo#208852), so clicking it raised "The action mail.mail_resend_message_action does not exist". The button now calls mail.message.retry_failed_message, which requeues and sends again the failed emails of the message through the standard mail.mail retry. When every email is sent, the message is marked as reviewed. The button is only shown when the message has a failed email that can be retried; otherwise the message has to be resent manually, as in Odoo 19, or set as reviewed. The unused retryFailedMessage of the FailedMessage component is removed, as it called the same removed action.
Gerloav
approved these changes
Oct 7, 2026
nachoserra-domatix
approved these changes
Oct 7, 2026
gerard-domatix
approved these changes
Oct 7, 2026
pablolopez-domatix
approved these changes
Oct 7, 2026
Member
|
Please, all the Domatix people, stop approving blindly the PRs, as that approvals are totally biased as can seen in the pattern. Do honest and real reviews. @alvaro-domatix start rebasing the branch over latest 19.0, which should fix the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In 19.0, clicking Retry on a failed message (chatter failed messages and the Failed mailbox) raises:
mail_trackingstill opens the core resend wizard, but Odoo removed the resend wizards in 19.0 (odoo/odoo#208852), so there is no action left to open.Fix
mail.message.retry_failed_message: requeues and sends again the failed emails (mail.mailinexception) of the message through the standardmail.mail.action_retry. When every email is sent, the message is marked as reviewed with the existingset_need_action_done, so it leaves the failed lists. It returns whether every email was sent, and the client shows a success or error notification.mail_tracking_can_retry, computed only for failed messages). Failures with no email left to retry (e.g. a bounce reported by the recipient server) are resent manually, as in Odoo 19, or set as reviewed.retryFailedMessageof theFailedMessagecomponent, which called the same removed action, is removed.How it was tested
test_retry_failed_messageandtest_retry_failed_message_without_failed_email.0 failed, 0 error(s) of 48 tests.pre-commit runon the changed files: all hooks pass.