Skip to content

[19.0][FIX] queue_job: skip on_fail when unconfigured #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Aug 31, 2026
Merged

[19.0][FIX] queue_job: skip on_fail when unconfigured #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions queue_job/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,10 +432,11 @@ def __init__(
self.env["queue.job.function"].sudo().job_config(self.job_function_name)
)
on_fail_method_name = self.job_config.on_fail_method_name
if on_fail_method_name:
if not _is_model_method(getattr(self.recordset, on_fail_method_name, None)):
raise TypeError("Job accepts only methods of Models")
self.on_fail_method_name = on_fail_method_name
if on_fail_method_name and not _is_model_method(
getattr(self.recordset, on_fail_method_name, None)
):
raise TypeError("Job accepts only methods of Models")
self.on_fail_method_name = on_fail_method_name

self.state = PENDING

Expand Down Expand Up @@ -875,6 +876,8 @@ def set_failed(self, **kw):
setattr(self, k, v)

def on_fail(self, fail_vals):
if not self.on_fail_method_name:
return
on_fail_func = getattr(self.recordset, self.on_fail_method_name, None)
if on_fail_func:
on_fail_func(**fail_vals)
Expand Down
11 changes: 11 additions & 0 deletions queue_job/tests/test_run_rob_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,14 @@ def test_runjob_on_fail(self):
RunJobController._runjob(self.env, job)
self.assertEqual(job.state, "failed")
self.assertEqual(mocked_hook.call_count, 1)

def test_runjob_on_fail_not_configured(self):
job = self.env["queue.job"].with_delay()._test_job(failure_rate=1)
with (
self.assertRaises(JobError),
patch("odoo.addons.queue_job.job.Job.in_temporary_env") as mocked_temp_env,
mute_logger("odoo.addons.queue_job.controllers.main"),
):
mocked_temp_env.return_value.__enter__.return_value = self.env
RunJobController._runjob(self.env, job)
self.assertEqual(job.state, "failed")
Loading