[19.0][MIG] report_py3o: Migration to 19.0#1132
Conversation
Replace README.md by README.rst (not finished)
Remove <data> in views Protect import of py3o libs Remove dep on base module Other small changes
Rename __openerp__.py to __manifest__.py
kopeyev
force-pushed
the
19.0-mig-report_py3o
branch
20 times, most recently
from
d72b1dd to
af7e4f6
Compare
There was a problem hiding this comment.
How do you deal with the [report_py3o] section of the Odoo conf file which contains the root_tmpl_path key ?
Shouldn't you have something like this ?https://github.com/OCA/queue/blob/d2a8e902eef111cee495e96bd8bc903155ba29ae/queue_job/jobrunner/__init__.py#L13
| """Check if the path is a trusted path for py3o templates.""" | ||
| real_path = os.path.realpath(path) | ||
| root_path = tools.config.get_misc("report_py3o", "root_tmpl_path") | ||
| root_path = tools.config.get("root_tmpl_path") |
There was a problem hiding this comment.
Почему убрал? Должен читать секцию report_py3o и данные оттуда
There was a problem hiding this comment.
в 19.0 убрали misc/get_misc, поэтому заменил на tools.config.get("root_tmpl_path")
There was a problem hiding this comment.
I've also seen that get_misc was removed but there is no automatic mechanism to get the report_py3o section in tools.config. So apart from the tests where you 'artificially' put root_tmpl_path directly into tools.config it won't work.
| from odoo.tests.common import TransactionCase | ||
|
|
||
| from odoo.addons.base.tests.test_mimetypes import PNG | ||
| from odoo.addons.base.tests.test_mimetypes import PNG as ODOO_PNG |
There was a problem hiding this comment.
В чем смысл брать переменную под другим названием?
| from ..models._py3o_parser_context import format_multiline_value | ||
| from ..models.ir_actions_report import PY3O_CONVERSION_COMMAND_PARAMETER | ||
| from ..models.py3o_report import TemplateNotFound | ||
| from ..wizard._py3o_parser_context import format_multiline_value | ||
| from ..wizard.py3o_report import Py3oReport, TemplateNotFound |
There was a problem hiding this comment.
Зачем в предыдущем коммите перенес _py3o_parser_context и py3o_report?
| users = self.env["res.users"].search([], limit=2) | ||
| if len(users) < 2: | ||
| users |= self.env["res.users"].create( | ||
| { | ||
| "name": "Test User 2", | ||
| "login": f"test_user_2_{self.env.cr.dbname}", | ||
| "email": f"test_user_2_{self.env.cr.dbname}@example.com", | ||
| } | ||
| ) | ||
| users.write({"image_1920": ODOO_PNG}) | ||
| self.assertGreaterEqual(len(users), 2) |
There was a problem hiding this comment.
Зачем пользователей создавать?
There was a problem hiding this comment.
нужно >= 2 записи, иначе _zip_results не вызывается -> patched_zip_results.call_count = 0 и тест падает:
2026-02-17 07:26:05,576 3034 ERROR odoo odoo.addons.report_py3o.tests.test_report_py3o: FAIL: TestReportPy3o.test_reports_merge_zip
Traceback (most recent call last):
File "/__w/reporting-engine/reporting-engine/report_py3o/tests/test_report_py3o.py", line 103, in test_reports_merge_zip
self.assertEqual(1, patched_zip_results.call_count)
AssertionError: 1 != 0
kopeyev
force-pushed
the
19.0-mig-report_py3o
branch
4 times, most recently
from
21a952a to
92af02a
Compare
kopeyev
force-pushed
the
19.0-mig-report_py3o
branch
from
92af02a to
62ca952
Compare
20 participants
No description provided.