Skip to content

[19.0][MIG] web_widget_x2many_2d_matrix: Migration to 19.0 - #3310

Open
bizzappdev wants to merge 153 commits into
OCA:19.0from
BizzAppDev-Systems:19.0-mig-web_widget_x2many_2d_matrix-BAD
Open

[19.0][MIG] web_widget_x2many_2d_matrix: Migration to 19.0#3310
bizzappdev wants to merge 153 commits into
OCA:19.0from
BizzAppDev-Systems:19.0-mig-web_widget_x2many_2d_matrix-BAD

Conversation

@bizzappdev

Copy link
Copy Markdown
Contributor

No description provided.

@hbrunn hbrunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration web_widget_x2many_2d_matrix

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Nov 14, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 14, 2025
46 tasks
@mav-adhoc

Copy link
Copy Markdown

LGTM

Comment on lines +29 to +30
column.text = column.value[1];
column.value = column.value[0];

@ferran-S73 ferran-S73 Feb 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bizzappdev This isn't working as expected. Since v19 Odoo stores m2o fields in javascript as a dict instead of the usual tuple with display name and id.

The correct way to access this data should be as follows

Suggested change
column.text = column.value[1];
column.value = column.value[0];
column.text = column.value.display_name;
column.value = column.value.id;

Please also check the rest of the module to make sure if this change is needed elsewhere

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! please also extend the tests to check this

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I opened a new PR fixing this issue as we needed this module. Feel free to use my fixed code in your PR if you wish

Comment on lines +29 to +30
column.text = column.value[1];
column.value = column.value[0];

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! please also extend the tests to check this

@CarlosRoca13

Copy link
Copy Markdown
Contributor

Hi @bizzappdev, can you rebase?

JasminSForgeFlow and others added 24 commits August 13, 2026 11:48
<=v15 used to pass the list view field node to the rendering widget,
enabling full configurability of the value field
…ckable)

it was possible to make the axis fields links to the record if they were
many2one fields
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/
Currently translated at 100.0% (7 of 7 strings)

Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/it/
use components to render axes and aggregates, allowing custom widgets
there
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/
Currently translated at 100.0% (8 of 8 strings)

Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/it/
@bizzappdev
bizzappdev force-pushed the 19.0-mig-web_widget_x2many_2d_matrix-BAD branch from c32a953 to c44602a Compare August 13, 2026 06:24
@OCA-git-bot OCA-git-bot added series:19.0 mod:web_widget_x2many_2d_matrix Module web_widget_x2many_2d_matrix labels Aug 13, 2026
@bizzappdev

Copy link
Copy Markdown
Contributor Author

Hi @bizzappdev, can you rebase?

Rebase done @CarlosRoca13

@CarlosRoca13 CarlosRoca13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat 👍

Please @hbrunn review this again 😄

@hbrunn hbrunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove/rephrase the generated bullshit comments in the tests.

And this must comply with https://github.com/OCA/.github/blob/master/AI_POLICY.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:web_widget_x2many_2d_matrix Module web_widget_x2many_2d_matrix series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.