[19.0][MIG] web_widget_x2many_2d_matrix: Migration to 19.0 - #3310
[19.0][MIG] web_widget_x2many_2d_matrix: Migration to 19.0#3310bizzappdev wants to merge 153 commits into
Conversation
hbrunn
left a comment
There was a problem hiding this comment.
/ocabot migration web_widget_x2many_2d_matrix
|
LGTM |
| column.text = column.value[1]; | ||
| column.value = column.value[0]; |
There was a problem hiding this comment.
@bizzappdev This isn't working as expected. Since v19 Odoo stores m2o fields in javascript as a dict instead of the usual tuple with display name and id.
The correct way to access this data should be as follows
| column.text = column.value[1]; | |
| column.value = column.value[0]; | |
| column.text = column.value.display_name; | |
| column.value = column.value.id; |
Please also check the rest of the module to make sure if this change is needed elsewhere
There was a problem hiding this comment.
good catch! please also extend the tests to check this
There was a problem hiding this comment.
Hi, I opened a new PR fixing this issue as we needed this module. Feel free to use my fixed code in your PR if you wish
| column.text = column.value[1]; | ||
| column.value = column.value[0]; |
There was a problem hiding this comment.
good catch! please also extend the tests to check this
b1da535 to
c32a953
Compare
|
Hi @bizzappdev, can you rebase? |
of one of the axes is a many2one field
[ADD] show grand total [IMP] classify floats as floats
[IMP] write formatted value to back to input
[RFR] and being on it, make reacting to changes in overrides simple
<=v15 used to pass the list view field node to the rendering widget, enabling full configurability of the value field
…ckable) it was possible to make the axis fields links to the record if they were many2one fields
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/
Currently translated at 100.0% (7 of 7 strings) Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/it/
use components to render axes and aggregates, allowing custom widgets there
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/
Currently translated at 100.0% (8 of 8 strings) Translation: web-18.0/web-18.0-web_widget_x2many_2d_matrix Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_x2many_2d_matrix/it/
c32a953 to
c44602a
Compare
Rebase done @CarlosRoca13 |
CarlosRoca13
left a comment
There was a problem hiding this comment.
Tested on runboat 👍
Please @hbrunn review this again 😄
hbrunn
left a comment
There was a problem hiding this comment.
please remove/rephrase the generated bullshit comments in the tests.
And this must comply with https://github.com/OCA/.github/blob/master/AI_POLICY.md
No description provided.