288: Add address element to generated html during digital post#301
Open
jekuaitk wants to merge 11 commits intoOS2Forms:developfrom
Open
288: Add address element to generated html during digital post#301jekuaitk wants to merge 11 commits intoOS2Forms:developfrom
jekuaitk wants to merge 11 commits intoOS2Forms:developfrom
Conversation
rimi-itk
requested changes
Feb 9, 2026
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Show resolved
Hide resolved
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
rimi-itk
requested changes
Feb 10, 2026
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
rimi-itk
requested changes
Feb 16, 2026
Collaborator
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
One serious issue must be addressed. Some suggestions may be considered.
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php
Outdated
Show resolved
Hide resolved
…talPostSubscriber.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…talPostSubscriber.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#288
Injects a html element into the generated html containing the required information (name, c/o, address, zip + city) when in a Digital Post context.
Styling is left to using parties as it may very well differ between installations, however an example styling is provided.
Note
This only modifies the PDF generated in the context of Digital Post. I.e. if the attachement is used in other contexts the address html will not be injected.