Skip to content

refactor(typescript-fetch): centralize date type handling in TypeScriptFetchClientCodegen - #24715

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:typescript-date-type-handling
Aug 18, 2026
Merged

refactor(typescript-fetch): centralize date type handling in TypeScriptFetchClientCodegen#24715
wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:typescript-date-type-handling

Conversation

@Mattias-Sehlstedt

@Mattias-Sehlstedt Mattias-Sehlstedt commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

There are several incentives to support better and consistent date handling for typescript-fetch #24714, #24637. I saw that they had to define the same thing over and over again when they were technically referring to the exact same thing.

I have gathered the definition in a single location so that any further change will be easier to follow and understand.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Centralizes date type handling in TypeScriptFetchClientCodegen to unify date/DateTime mapping and type checks. Behavior unchanged: with dateLibrary=date, both map to TypeScript Date; otherwise both map to string.

  • Introduces constants DATE_TYPE, DATE_TIME_TYPE, and TS_DATE_TYPE; updates mappings to use them.
  • Adds shared helpers isDateType and isDateTimeType; parameter/property/model checks now delegate to them.
  • Minor cleanup: use isEmpty() for cm.imports in parseImports.
  • Verify typescript-fetch samples produce no generated diffs.

Written for commit 18b51b2. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@Mattias-Sehlstedt
Mattias-Sehlstedt force-pushed the typescript-date-type-handling branch from bc4ca5d to 1c9efe5 Compare August 17, 2026 17:25
@Mattias-Sehlstedt
Mattias-Sehlstedt force-pushed the typescript-date-type-handling branch from 1c9efe5 to 18b51b2 Compare August 17, 2026 19:42
@wing328
wing328 merged commit 44d4697 into OpenAPITools:master Aug 18, 2026
15 checks passed
@wing328 wing328 added Client: TypeScript Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Aug 18, 2026
@wing328 wing328 added this to the 7.25.0 milestone Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: TypeScript Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants