Open
Conversation
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
…rejections Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
…reason classification Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
…ware Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
shunr-hpe
approved these changes
Apr 7, 2026
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
13 tasks
…s and platform support Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Collaborator
|
When setting Apr 10 17:01:47 openchami-testing.novalocal smd[3892921]: 2026/04/10 17:01:47.817541 main.go:1058: Initializing authentication with backend "tokensmith"...
Apr 10 17:01:47 openchami-testing.novalocal smd[3892921]: 2026/04/10 17:01:47.820772 main.go:1062: failed to initialize auth token: failed to fetch "http://opaal:3333/key>
Apr 10 17:01:52 openchami-testing.novalocal smd[3892921]: 2026/04/10 17:01:52.824118 main.go:1062: failed to initialize auth token: failed to fetch "http://opaal:3333/key>Do we still need to set |
shunr-hpe
approved these changes
Apr 13, 2026
| COPY smd / | ||
| COPY smd-loader / | ||
| COPY smd-init / | ||
| ARG TARGETPLATFORM |
Collaborator
There was a problem hiding this comment.
Possibly change to the following where the current directory is the default value
ARG TARGETPLATFORM=.
This allows me to run
make binaries image
Alternately tell me how you build smd.
Collaborator
|
I ran the functional tests (CT tests) against these changes and they passed. See the README on how to run these. The functional tests run against an SMD instance that has done its own discovery, as such, the tests are not as applicable to OpenCHAMI, but it's still nice to see them pass. The unit tests also passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new, pluggable authentication system for SMD, allowing selection between the legacy JWT backend and a new TokenSmith-based backend. It adds new startup flags and environment variables for authentication configuration, improves logging for authentication failures, and refactors authentication initialization and verification logic for clarity and extensibility. Documentation is updated to describe the new authentication options and runtime behavior.
Authentication system improvements:
legacybackend and a newtokensmithbackend, selectable via the-auth-backendflag orSMD_AUTH_BACKENDenvironment variable. The TokenSmith backend validates issuer and audience in addition to JWKS. [1] [2] [3] [4] [5]-auth-issuer/SMD_AUTH_ISSUERand-auth-audiences/SMD_AUTH_AUDIENCES, required for the TokenSmith backend. [1] [2] [3]Middleware and route handling:
Verification and claims extraction:
Logging and diagnostics:
Documentation and dependencies:
github.com/openchami/tokensmithand updating several libraries. [1] [2] [3]Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and emailType of Change
For more info, see Contributing Guidelines.