Conversation
Deploying geodatalytics with
|
| Latest commit: |
03671f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://378b3662.geodatalytics.pages.dev |
| Branch Preview URL: | https://demo-fixes.geodatalytics.pages.dev |
BryonLewis
left a comment
There was a problem hiding this comment.
a few questions, I don't think any are blockers and could be implemented/updated if required.
brianhelba
left a comment
There was a problem hiding this comment.
1 question, 1 small code simplification
| @@ -0,0 +1,2 @@ | |||
| from .dataset import convert_dataset | |||
| from .chart import convert_chart | |||
There was a problem hiding this comment.
I think we eventually need to be importing all of the tasks to register them, but that might be outside the scope of this PR.
brianhelba
left a comment
There was a problem hiding this comment.
I haven't reviewed the Vue code, but the Python side makes sense.
| @@ -0,0 +1,2 @@ | |||
| from .dataset import convert_dataset | |||
| from .chart import convert_chart | |||
There was a problem hiding this comment.
You can add:
__all__ = [
'convert_chart',
'convert_dataset',
]to make it happy about unused imports.
There was a problem hiding this comment.
You might be able to just do:
import .chart
import .datasetinstead.
BryonLewis
left a comment
There was a problem hiding this comment.
I think the changes made to the getColorPropsCoverage make it clearer what is happening, thanks.
This PR fixes some miscellaneous behavior that I discovered when preparing my demo for the webinar:
GuardianFilterinaccess_control.py