Skip to content

Misc fixes for webinar demo#355

Open
annehaley wants to merge 11 commits intomasterfrom
demo-fixes
Open

Misc fixes for webinar demo#355
annehaley wants to merge 11 commits intomasterfrom
demo-fixes

Conversation

@annehaley
Copy link
Collaborator

@annehaley annehaley commented Mar 17, 2026

This PR fixes some miscellaneous behavior that I discovered when preparing my demo for the webinar:

  • The legend panel should only show that feature color props are being applied if those color props are present on some features.
  • View states were not being fetched properly due to a bug in the GuardianFilter in access_control.py
  • Fixed project selection behavior in project configuration page (it would reselect the previous project after creating a new project)
  • Added a trailing slash to the API function for deleting a dataset
  • Imported non-analytics tasks to ensure that they are registered by celery

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 17, 2026

Deploying geodatalytics with  Cloudflare Pages  Cloudflare Pages

Latest commit: 03671f5
Status: ✅  Deploy successful!
Preview URL: https://378b3662.geodatalytics.pages.dev
Branch Preview URL: https://demo-fixes.geodatalytics.pages.dev

View logs

Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions, I don't think any are blockers and could be implemented/updated if required.

@annehaley annehaley requested a review from BryonLewis March 20, 2026 15:17
Copy link
Collaborator

@brianhelba brianhelba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, 1 small code simplification

@@ -0,0 +1,2 @@
from .dataset import convert_dataset
from .chart import convert_chart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we eventually need to be importing all of the tasks to register them, but that might be outside the scope of this PR.

Copy link
Collaborator

@brianhelba brianhelba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the Vue code, but the Python side makes sense.

@@ -0,0 +1,2 @@
from .dataset import convert_dataset
from .chart import convert_chart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add:

__all__ = [
    'convert_chart',
    'convert_dataset',
]

to make it happy about unused imports.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to just do:

import .chart
import .dataset

instead.

Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes made to the getColorPropsCoverage make it clearer what is happening, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants