Streamline time slider loading#327
Open
1ec5 wants to merge 2 commits into
Open
Conversation
1ec5
commented
Oct 28, 2025
| let ohmlayer; | ||
| map.eachLayer(function (layer) { // there's only 1 or 0 time layers at a time, so this works | ||
| if (historicalLayerKeys.indexOf(layer.options.layerId) !== -1) ohmlayer = layer; | ||
| if (layer instanceof L.OSM.OHM) ohmlayer = layer; |
Member
Author
There was a problem hiding this comment.
This assumes every instance of L.OSM.OHM is time-enabled. That’s currently true, but if we ever choose to publish an all-time cumulative style that isn’t filtered by date, then we’ll need to push this decision down to each instance of L.OSM.OHM via a new property in layers.yml.
1ec5
force-pushed
the
1ec5-timeslider-control-subclass
branch
from
ba31d08 to
41d4dee
Compare
Restored normal page loading to be synchronous. Load the time slider synchronously as part of page loading. Fixed a bad merge in directions.js. Removed inconsistent support for date parameters as query parameters, leaving only support for date parameters as hash parameters.
1ec5
force-pushed
the
1ec5-timeslider-control-subclass
branch
from
41d4dee to
f61a503
Compare
danvk
reviewed
May 8, 2026
| @@ -85,16 +84,5 @@ function addOpenHistoricalMapTimeSlider (map, params, onreadycallback) { | |||
| slideroptions.vectorLayer = ohmlayer; | |||
There was a problem hiding this comment.
Do you want to move the if (getHistoryLayerIfShowing()) check in here? So if (ohmlayer)?
If getHistoryLayerIfShowing() returns null, will this get called again by the 'baselayerchange' handler? (I'm just wondering about the source of the race condition.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores normal page loading to be synchronous and loads the time slider synchronously as part of page loading. I’ve also fixed a bad merge in directions.js (which is currently inaccessible). The new streamlined initialization code only supports date parameters as hash parameters (after the
#). I’ve removed support for date parameters as query parameters (after the?), which were only supported on a couple of the pages and are probably rarely used.This also removes a hard-coded list of time-enabled layer IDs, so there are fewer steps to remember when adding a new layer.
Fixes OpenHistoricalMap/issues#1179.