Open
Conversation
Signed-off-by: Greg Thole <[email protected]>
gthole
force-pushed
the
vtn-reporting-hooks
branch
from
1be2a69 to
3b285d6
Compare
Signed-off-by: Greg Thole <[email protected]>
Signed-off-by: Greg Thole <[email protected]>
axmsoftware
approved these changes
Nov 26, 2024
Contributor
axmsoftware
left a comment
axmsoftware
left a comment
There was a problem hiding this comment.
Implements a missing feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow clients to implement VTN-to-VEN reports with poll callback handlers.
Add callback handlers for
oadrRegisterReportandoadrUpdateReportPoll messages.Notes:
oadrRegisterReportwill still return anoadrRegisteredReportwith no requested reports as before, so there is no change to that behavior unless a VEN client adds a handler.oadrUpdateReportpreviously would crash the client since it would attempt to call an_on_reportmethod that does not exist on the Client class. Now it will return anoadrUpdatedReportto the VTN and call a handler.Many thanks for this excellent project!