docs: improve README setup clarity and Docker instructions#342
docs: improve README setup clarity and Docker instructions#342incursio-xd wants to merge 1 commit intoOpenMS:mainfrom
Conversation
📝 WalkthroughWalkthroughREADME.md documentation updates standardizing and expanding content across multiple sections. Changes include refined wording, expanded "Run Locally" prerequisites, clarified Docker setup with two-Dockerfile explanation, explicit command examples, security notes, and updated references formatting. Changes
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 92-94: Update the three fenced code blocks in README that
currently lack language specifiers: add "env" (or "text") to the block
containing GITHUB_TOKEN (the block showing GITHUB_TOKEN=<your-github-token>),
add "text" (or "console") to the Docker build output block (the block showing
"[+] Running 2/2 ... Built / Started"), and add "text" (or "console") to the
docker compose ps output block (the block showing "CONTAINER ID IMAGE ...
4abe0603e521 ..."); ensure each opening triple-backtick includes the chosen
language label (e.g., ```env, ```text) so markdownlint MD040 is satisfied.
| ``` | ||
| GITHUB_TOKEN=<your-github-token> | ||
| ``` |
There was a problem hiding this comment.
Add language specifiers to the three fenced code blocks flagged by markdownlint (MD040).
Three code blocks are missing language identifiers, which triggers markdownlint rule MD040 in CI:
- Line 92:
.envcontents → use`envor`text - Line 109: Docker build output → use
`textor`console - Line 116:
docker compose psoutput → use`textor`console
📝 Proposed fix
- ```
+ ```env
GITHUB_TOKEN=<your-github-token>
```- ```
+ ```text
[+] Running 2/2
✔ openms-streamlit-template Built
✔ Container openms-streamlit-template Started
```- ```
+ ```text
CONTAINER ID IMAGE ...
4abe0603e521 ...
```Also applies to: 109-113, 116-119
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 92-92: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 92 - 94, Update the three fenced code blocks in
README that currently lack language specifiers: add "env" (or "text") to the
block containing GITHUB_TOKEN (the block showing
GITHUB_TOKEN=<your-github-token>), add "text" (or "console") to the Docker build
output block (the block showing "[+] Running 2/2 ... Built / Started"), and add
"text" (or "console") to the docker compose ps output block (the block showing
"CONTAINER ID IMAGE ... 4abe0603e521 ..."); ensure each opening
triple-backtick includes the chosen language label (e.g., ```env, ```text) so
markdownlint MD040 is satisfied.
|
This is a huge diff that does not really change much. Could you reopen a PR that fixes the numbering issues? The rest of the doc changes seem unnecessary to me. Especially, we do not need to show expected docker output. |
Fixes documentation issues in README.md.
Changes:
docker composesyntax.envsecurity note to avoid accidental token commitsThese are small documentation fixes with no functional changes.
Related to: #174
Summary by CodeRabbit
Release Notes