Skip to content

front: add duration cell in new table#14733

Merged
Akctarus merged 4 commits intodevfrom
tmn/front/table/add-duration-cell
Jan 30, 2026
Merged

front: add duration cell in new table#14733
Akctarus merged 4 commits intodevfrom
tmn/front/table/add-duration-cell

Conversation

@Akctarus
Copy link
Copy Markdown
Contributor

closes #14636

@Akctarus Akctarus requested a review from a team as a code owner January 14, 2026 10:22
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Jan 14, 2026
@Akctarus Akctarus marked this pull request as draft January 14, 2026 10:22
@Akctarus Akctarus force-pushed the tmn/front/table/add-duration-cell branch from ccd6989 to ab21b4b Compare January 14, 2026 10:23
@Akctarus Akctarus marked this pull request as ready for review January 23, 2026 09:54
@Akctarus Akctarus force-pushed the tmn/front/table/add-duration-cell branch 2 times, most recently from 413032b to 66d352e Compare January 23, 2026 13:50
@Akctarus Akctarus requested review from achrafmohye, emersion and theocrsb and removed request for achrafmohye January 23, 2026 14:27
Comment thread front/src/modules/timesStops/DurationCell.tsx Outdated
Comment thread front/src/modules/timesStops/TimesStopsTable.tsx Outdated
Comment thread front/src/modules/timesStops/DurationCell.tsx Outdated
Comment thread front/src/modules/timesStops/TimesStopsTable.tsx Outdated
Comment thread front/src/modules/timesStops/DurationCell.tsx Outdated
Comment thread front/src/modules/timesStops/styles/_durationCell.scss
Comment thread front/src/modules/timesStops/styles/_durationCell.scss Outdated
@Akctarus Akctarus force-pushed the tmn/front/table/add-duration-cell branch from 66d352e to 9f0cb31 Compare January 26, 2026 13:32
@kmer2016 kmer2016 requested review from kmer2016 and removed request for emersion January 27, 2026 10:12
Comment thread front/src/modules/timesStops/DurationCell.tsx Outdated
Comment thread front/src/modules/timesStops/DurationCell.tsx Outdated
Comment thread front/src/modules/timesStops/TimesStopsTable.tsx Outdated
Comment thread front/src/modules/timesStops/TimesStopsTable.tsx Outdated
Comment thread front/src/modules/timesStops/DurationCell.tsx Outdated
@Akctarus Akctarus force-pushed the tmn/front/table/add-duration-cell branch 4 times, most recently from 28f88fa to 28f1649 Compare January 28, 2026 16:38
Comment thread front/src/modules/timesStops/styles/_durationCell.scss Outdated
Comment thread front/src/modules/timesStops/styles/_durationCell.scss Outdated
Comment thread front/src/modules/timesStops/styles/_durationCell.scss
Comment thread front/src/modules/timesStops/DurationCell.tsx
Comment thread front/src/modules/timesStops/DurationCell.tsx
@theocrsb
Copy link
Copy Markdown
Contributor

When I enter a value, I click outside and click again in the box, and the value is reset.
Deletion seems OK, navigation within the cell also seems OK.

@theocrsb
Copy link
Copy Markdown
Contributor

the grid pattern and the color around it do not exist

image

Comment thread front/src/modules/timesStops/styles/_durationCell.scss Outdated
@theocrsb theocrsb requested a review from kmer2016 January 28, 2026 18:11
@Akctarus Akctarus requested a review from achrafmohye January 29, 2026 10:03
@Akctarus Akctarus force-pushed the tmn/front/table/add-duration-cell branch from 28f1649 to 43c2fc1 Compare January 29, 2026 10:54
@Akctarus Akctarus requested a review from theocrsb January 29, 2026 15:24
@kmer2016
Copy link
Copy Markdown
Contributor

kmer2016 commented Jan 29, 2026

When you start typing in the DurationCell, the input border becomes bold (browser default focus outline - Chromium)

Capture.video.du.2026-01-29.18-20-27.webm

Copy link
Copy Markdown
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akctarus Akctarus force-pushed the tmn/front/table/add-duration-cell branch from 57baebf to aead701 Compare January 30, 2026 09:53
@Akctarus Akctarus enabled auto-merge January 30, 2026 09:54
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus force-pushed the tmn/front/table/add-duration-cell branch from aead701 to 5c8bede Compare January 30, 2026 09:58
@Akctarus Akctarus added this pull request to the merge queue Jan 30, 2026
Merged via the queue into dev with commit 80076d1 Jan 30, 2026
29 checks passed
@Akctarus Akctarus deleted the tmn/front/table/add-duration-cell branch January 30, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create duration cell for new table

4 participants