Skip to content

front: use local track name#14780

Merged
Uriel-Sautron merged 7 commits intohai/editoast-track-reference-filterfrom
usn/front-use-local-track
Jan 27, 2026
Merged

front: use local track name#14780
Uriel-Sautron merged 7 commits intohai/editoast-track-reference-filterfrom
usn/front-use-local-track

Conversation

@Uriel-Sautron
Copy link
Copy Markdown
Contributor

@Uriel-Sautron Uriel-Sautron commented Jan 19, 2026

The new variable local_track_name must be used for:

  • selecting an op on the map
  • input / output simulation table
  • simulation sheet
  • STDCM result

close #14323

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner January 19, 2026 10:44
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Jan 19, 2026
@Uriel-Sautron Uriel-Sautron force-pushed the usn/front-use-local-track branch from c14d3cf to 7d7cef2 Compare January 19, 2026 13:00
Copy link
Copy Markdown
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files still need to be updated :

  • usePathStepsMetadata.ts,
  • TimeStopsInput.tsx :
    ➡️ We could simplify the fetchAndFormatRows function like :
const fetchAndFormatRows = async () => {
      if (pathStepsAndSuggestedOPs) {
        const formatedRows = formatSuggestedViasToRowVias(
          pathStepsAndSuggestedOPs,
          pathSteps || [],
          t,
          startTime,
          TableType.Input
        );
        setRows(updateDaySinceDeparture(formatedRows, { keepFirstIndexArrival: true }));
      }
    };

Comment thread front/src/modules/timesStops/hooks/useTimesStopsTableData.ts
Copy link
Copy Markdown
Member

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an infra with local track name does not work since the backend does not take it into account. So There is a dependency with this PR: #14807

Copy link
Copy Markdown
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @SarahBellaha 's comments.

@Uriel-Sautron
Copy link
Copy Markdown
Contributor Author

  • usePathStepsMetadata

➡️ We could simplify the fetchAndFormatRows function like :

const fetchAndFormatRows = async () => {
      if (pathStepsAndSuggestedOPs) {
        const formatedRows = formatSuggestedViasToRowVias(
          pathStepsAndSuggestedOPs,
          pathSteps || [],
          t,
          startTime,
          TableType.Input
        );
        setRows(updateDaySinceDeparture(formatedRows, { keepFirstIndexArrival: true }));
      }
    };

Refactoring is not possible because the trackName is undefined in the pathstep.

@Uriel-Sautron Uriel-Sautron force-pushed the usn/front-use-local-track branch 2 times, most recently from 38d31b0 to bafaf2d Compare January 22, 2026 14:29
@Uriel-Sautron Uriel-Sautron requested review from a team and shenriotpro January 22, 2026 14:29
@github-actions github-actions Bot added the area:integration-tests Work on Integration test, by nature related to different services label Jan 22, 2026
@Uriel-Sautron Uriel-Sautron force-pushed the usn/front-use-local-track branch from bafaf2d to d1b5520 Compare January 22, 2026 14:37
@Uriel-Sautron Uriel-Sautron requested review from Yohh and removed request for Yohh January 23, 2026 07:54
@shenriotpro
Copy link
Copy Markdown
Contributor

OK for tests/, but i'll wait for the dependency so we can manually test

@Uriel-Sautron Uriel-Sautron changed the base branch from dev to hai/editoast-track-reference-filter January 23, 2026 10:14
@Uriel-Sautron Uriel-Sautron requested review from a team as code owners January 23, 2026 10:14
@Uriel-Sautron Uriel-Sautron requested a review from Khoyo January 23, 2026 10:14
@Uriel-Sautron Uriel-Sautron changed the base branch from hai/editoast-track-reference-filter to dev January 23, 2026 10:16
@Uriel-Sautron Uriel-Sautron removed request for a team January 23, 2026 10:16
@Uriel-Sautron Uriel-Sautron force-pushed the usn/front-use-local-track branch from d1b5520 to 5a1280f Compare January 26, 2026 13:05
@Uriel-Sautron Uriel-Sautron changed the base branch from dev to hai/editoast-track-reference-filter January 26, 2026 13:10
@hamz2a hamz2a force-pushed the hai/editoast-track-reference-filter branch from 0071f31 to 62f1319 Compare January 26, 2026 13:15
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com>
@Uriel-Sautron Uriel-Sautron force-pushed the usn/front-use-local-track branch from 5a1280f to 9a276e2 Compare January 27, 2026 10:40
@Uriel-Sautron Uriel-Sautron merged commit d4450b7 into hai/editoast-track-reference-filter Jan 27, 2026
18 checks passed
@Uriel-Sautron Uriel-Sautron deleted the usn/front-use-local-track branch January 27, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use local track in the TOD (front)

5 participants