Conversation
There is a db_id of 0 (for example for vnode 0 in a riak cluster) - so naming databases without an id 0 creates confusion
* Test and fix - issue with folding beyond JournalSQN Test previously fails, as even on a fast machine the fold goes on for 5s beyond the last object found. With change to reduce batch size, and stop when batch goes beyond JournalSQN - success with << 100ms spent folding after the last object discovered * Wait after suite for delete_pending to close martinsumner#462 * Avoid processing key changes in object fold runner As the key changes are going to be discarded
* Test of sqn_order fold with compaction Exposes issue with delete_pending not supporting cdb_scan. * Reduce default max_run_length to ensure compaction triggers
…ring Journal check (martinsumner#472) * Add ability to defer fetching a value in the fold - but without requring check presence Reduces the cost of using head folds in partition repairs, where the check is not necessary as a fetch failure will be caught and prompt read repair. * Update types for JournalCheck * Fix tuple mistake (martinsumner#473) Otherwise leveled_pclerk will crash if there is a partial merge that results in an an empty addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update from upstream approved PRs to resolve martinsumner#465 and martinsumner#468