.github/workflows: Migrate workflows to Blacksmith runners#391
.github/workflows: Migrate workflows to Blacksmith runners#391blacksmith-sh[bot] wants to merge 2 commits intomasterfrom
Conversation
Deploying maple with
|
| Latest commit: |
6bb8906
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://589ec6b8.maple-ca8.pages.dev |
| Branch Preview URL: | https://blacksmith-migration-9e8ab65.maple-ca8.pages.dev |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Greptile OverviewGreptile SummaryThis PR migrates GitHub Actions workflows from GitHub-hosted runners to Blacksmith runners for improved performance. Changes Made:
Critical Issue Found: Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Old as GitHub Runners
participant New as Blacksmith Runners
participant Cache as Cache Layer
Note over Dev,Cache: Migration from GitHub to Blacksmith Runners
Dev->>GH: Push code / Create PR
GH->>GH: Read workflow YAML files
alt Before Migration
GH->>Old: Provision ubuntu-latest-8-cores
Old->>Cache: Fetch dependencies (slow)
Old->>Old: Run build/test steps
Old->>GH: Return results
end
alt After Migration
GH->>New: Provision blacksmith-8vcpu-ubuntu-2404
New->>Cache: Fetch from co-located cache (4x faster)
New->>New: Run build/test steps (2x faster CPU)
New->>Cache: Store Docker layers (40x faster)
New->>GH: Return results (faster overall)
end
Note over GH,New: Jobs affected: android-build (3 jobs),<br/>claude (1 job), desktop-build (1 job),<br/>release (5 jobs)
|
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 72:72
Comment:
conditional check references old runner name, causing Linux sccache installation to be skipped
```suggestion
if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 91:91
Comment:
conditional check references old runner name, causing Linux dependencies to be skipped
```suggestion
if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```
How can I resolve this? If you propose a fix, please make it concise. |
cbc409b to
0a55089
Compare
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 72:72
Comment:
Conditional still checks for old runner name `ubuntu-latest-8-cores`, but line 35 now uses `blacksmith-8vcpu-ubuntu-2404`.
```suggestion
if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 91:91
Comment:
Conditional still checks for old runner name `ubuntu-latest-8-cores`, but line 35 now uses `blacksmith-8vcpu-ubuntu-2404`.
```suggestion
if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```
How can I resolve this? If you propose a fix, please make it concise. |
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 72:72
Comment:
The platform check references `ubuntu-latest-8-cores` but the matrix now uses `blacksmith-8vcpu-ubuntu-2404` (line 35). This conditional will never be true, causing sccache installation to be skipped on Linux builds.
```suggestion
if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 91:91
Comment:
The platform check references `ubuntu-latest-8-cores` but the matrix now uses `blacksmith-8vcpu-ubuntu-2404` (line 35). This conditional will never be true, causing Linux dependencies installation to be skipped.
```suggestion
if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```
How can I resolve this? If you propose a fix, please make it concise. |
To whomever may be reviewing this PR,
Blacksmith is the fastest way to run your GitHub Actions.
What does this PR change?
This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:
runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.FAQ