Skip to content

.github/workflows: Migrate workflows to Blacksmith runners#391

Closed
blacksmith-sh[bot] wants to merge 2 commits intomasterfrom
blacksmith-migration-9e8ab65
Closed

.github/workflows: Migrate workflows to Blacksmith runners#391
blacksmith-sh[bot] wants to merge 2 commits intomasterfrom
blacksmith-migration-9e8ab65

Conversation

@blacksmith-sh
Copy link

@blacksmith-sh blacksmith-sh bot commented Jan 20, 2026

To whomever may be reviewing this PR,

Blacksmith is the fastest way to run your GitHub Actions.

What does this PR change?

This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:

  1. Your selected workflows will now run on Blacksmith's 2x faster hardware (e.g., runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.
  2. Your jobs running on Blacksmith will now have all official GitHub and popular third-party cache actions automatically interact with our 4x faster, colocated cache. Learn more about Blacksmith's actions cache.
  3. Your GitHub Actions will now actually be observable. Learn more about Blacksmith's logging and other observability features.
  4. Your Docker builds will now automatically share their Docker layer cache, resulting in up to 40x faster builds. Learn more about Blacksmith's Docker layer caching.

FAQ

  • Is this free? The first 3,000 minutes per month are free.
  • Who uses Blacksmith? Clerk, Ashby, VEED, and 600+ others.
  • What's the catch? There is none. Merge this thing already.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2026

Deploying maple with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6bb8906
Status: ✅  Deploy successful!
Preview URL: https://589ec6b8.maple-ca8.pages.dev
Branch Preview URL: https://blacksmith-migration-9e8ab65.maple-ca8.pages.dev

View logs

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Overview

Greptile Summary

This PR migrates GitHub Actions workflows from GitHub-hosted runners to Blacksmith runners for improved performance.

Changes Made:

  • Migrated 10 total job runners across 4 workflow files to Blacksmith infrastructure
  • Updated android-build.yml: 3 jobs now use blacksmith-8vcpu-ubuntu-2404
  • Updated claude.yml: 1 job now uses blacksmith-4vcpu-ubuntu-2404
  • Updated desktop-build.yml: 1 job now uses blacksmith-8vcpu-ubuntu-2404
  • Updated release.yml: 5 jobs now use blacksmith-8vcpu-ubuntu-2404
  • Cleaned up README.md by removing stray text

Critical Issue Found:
In release.yml, two conditional checks on lines 72 and 91 still reference the old runner name ubuntu-latest-8-cores instead of the new blacksmith-8vcpu-ubuntu-2404. This will cause the sccache installation and Linux dependencies installation steps to be skipped during release builds, which could lead to build failures or significantly slower builds.

Confidence Score: 2/5

  • This PR has a critical logic error that will break Linux release builds.
  • While the migration strategy is sound and most changes are correct, the inconsistent conditional checks in release.yml create a critical bug. The Linux release builds will skip installing sccache and system dependencies, which will likely cause compilation failures or severely degraded performance. This is a blocking issue that must be fixed before merge.
  • .github/workflows/release.yml requires immediate attention - the conditional platform checks on lines 72 and 91 must be updated to match the new runner name.

Important Files Changed

Filename Overview
.github/workflows/release.yml Migrated matrix platform and Android jobs to Blacksmith runners, but conditional checks on lines 72 and 91 still reference old runner name, causing Linux builds to skip critical installation steps.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant Old as GitHub Runners
    participant New as Blacksmith Runners
    participant Cache as Cache Layer
    
    Note over Dev,Cache: Migration from GitHub to Blacksmith Runners
    
    Dev->>GH: Push code / Create PR
    GH->>GH: Read workflow YAML files
    
    alt Before Migration
        GH->>Old: Provision ubuntu-latest-8-cores
        Old->>Cache: Fetch dependencies (slow)
        Old->>Old: Run build/test steps
        Old->>GH: Return results
    end
    
    alt After Migration
        GH->>New: Provision blacksmith-8vcpu-ubuntu-2404
        New->>Cache: Fetch from co-located cache (4x faster)
        New->>New: Run build/test steps (2x faster CPU)
        New->>Cache: Store Docker layers (40x faster)
        New->>GH: Return results (faster overall)
    end
    
    Note over GH,New: Jobs affected: android-build (3 jobs),<br/>claude (1 job), desktop-build (1 job),<br/>release (5 jobs)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Additional Comments (2)

.github/workflows/release.yml
conditional check references old runner name, causing Linux sccache installation to be skipped

        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 72:72

Comment:
conditional check references old runner name, causing Linux sccache installation to be skipped

```suggestion
        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```

How can I resolve this? If you propose a fix, please make it concise.

.github/workflows/release.yml
conditional check references old runner name, causing Linux dependencies to be skipped

        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 91:91

Comment:
conditional check references old runner name, causing Linux dependencies to be skipped

```suggestion
        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```

How can I resolve this? If you propose a fix, please make it concise.

@AnthonyRonning AnthonyRonning force-pushed the blacksmith-migration-9e8ab65 branch from cbc409b to 0a55089 Compare January 20, 2026 19:51
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Additional Comments (2)

.github/workflows/release.yml
Conditional still checks for old runner name ubuntu-latest-8-cores, but line 35 now uses blacksmith-8vcpu-ubuntu-2404.

        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 72:72

Comment:
Conditional still checks for old runner name `ubuntu-latest-8-cores`, but line 35 now uses `blacksmith-8vcpu-ubuntu-2404`.

```suggestion
        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```

How can I resolve this? If you propose a fix, please make it concise.

.github/workflows/release.yml
Conditional still checks for old runner name ubuntu-latest-8-cores, but line 35 now uses blacksmith-8vcpu-ubuntu-2404.

        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 91:91

Comment:
Conditional still checks for old runner name `ubuntu-latest-8-cores`, but line 35 now uses `blacksmith-8vcpu-ubuntu-2404`.

```suggestion
        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```

How can I resolve this? If you propose a fix, please make it concise.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Additional Comments (2)

.github/workflows/release.yml
The platform check references ubuntu-latest-8-cores but the matrix now uses blacksmith-8vcpu-ubuntu-2404 (line 35). This conditional will never be true, causing sccache installation to be skipped on Linux builds.

        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 72:72

Comment:
The platform check references `ubuntu-latest-8-cores` but the matrix now uses `blacksmith-8vcpu-ubuntu-2404` (line 35). This conditional will never be true, causing sccache installation to be skipped on Linux builds.

```suggestion
        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```

How can I resolve this? If you propose a fix, please make it concise.

.github/workflows/release.yml
The platform check references ubuntu-latest-8-cores but the matrix now uses blacksmith-8vcpu-ubuntu-2404 (line 35). This conditional will never be true, causing Linux dependencies installation to be skipped.

        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 91:91

Comment:
The platform check references `ubuntu-latest-8-cores` but the matrix now uses `blacksmith-8vcpu-ubuntu-2404` (line 35). This conditional will never be true, causing Linux dependencies installation to be skipped.

```suggestion
        if: matrix.platform == 'blacksmith-8vcpu-ubuntu-2404'
```

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@AnthonyRonning AnthonyRonning deleted the blacksmith-migration-9e8ab65 branch January 29, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant