Fix pkgcs11 vcpkg port installing both debug and release files unconditionally#1007
Open
lcruz99 wants to merge 1 commit intoOpenVPN:masterfrom
Open
Fix pkgcs11 vcpkg port installing both debug and release files unconditionally#1007lcruz99 wants to merge 1 commit intoOpenVPN:masterfrom
lcruz99 wants to merge 1 commit intoOpenVPN:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
VCPKG_BUILD_TYPEis set (either toreleaseordebug), windows build fails during the vcpkg install phase when building pkcs11-helper.pkcs11-helper portfile unconditionally attempts to install both release and debug artifacts:
The PR fixes this by wrapping the release and debug file(INSTALL) commands with VCPKG_BUILD_TYPE guards, consistent with the existing pattern in the pkgconfig section: