-
-
Notifications
You must be signed in to change notification settings - Fork 313
feat: add rules argument for getUserInput #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xiaoxustudio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过为 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
这个 PR 为 getUserInput 添加了正则表达式验证功能,整体实现得不错。我发现了一个潜在的严重 bug,当 userInput 元素不存在时,代码会尝试访问 null 的属性导致程序崩溃。我已经提供了一个修复建议。另外,我还建议改进验证失败时的错误提示方式,以提升用户体验。请查看具体的评论。
| if (rule) { | ||
| const reg = tryToRegex(rule, ruleFlag); | ||
| if (reg && !reg.test(userInput.value)) { | ||
| if (ruleText) alert(ruleText.replaceAll(/\$0/g, userInput.value)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为
getUserInput添加正则验证功能参数新增参数:
g,i等写法示例:
当正则出现错误时,会跳过验证,并在控制台打印信息

close #769 #782