Repository navigation
Conversation
HandSonic
force-pushed
the
fix/snowflake-view-definition
branch
from
September 3, 2026 18:47
d305d2c to
5ca0306
Compare
Align existing OtterMind/Chat2DB PR OtterMind#2822 while preserving its focused fix.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
Snowflake
INFORMATION_SCHEMA.VIEWS.VIEW_DEFINITIONalready contains the view query definition. The previous implementation searched that value for a lowercaseasand returned a substring, which truncated uppercase/no-ASdefinitions, returned only the suffix after lowercase aliases, and threw for null definitions. This change preserves the JDBC definition verbatim while retaining the existing view identity and empty-result behavior.Affected surfaces
Verification
SnowflakeMetaDataTest: 5 tests passed, 0 failures/errors/skips.git diff --check: passed.5ca0306a45273899c4dad41396b29f4367004176.AS, lowercase aliases, noAS, null definitions, and empty result sets.Risk and compatibility
VIEW_DEFINITIONcontract without parsing or rewriting the returned SQL.Reviewer map
SnowflakeMetaData.viewandSnowflakeMetaDataTest.DEFINITIONvalue, null throws, or an empty result loses database/schema/view identity.d305d2c69; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, CI monitoring, and adversarial review.