Conversation
HandSonic
force-pushed
the
fix/view-table-paging-settlement
branch
from
September 3, 2026 08:35
f9d6e59 to
262fa60
Compare
HandSonic
force-pushed
the
fix/view-table-paging-settlement
branch
from
September 3, 2026 21:08
262fa60 to
d5aac09
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
Table-browser paging treated a
success=falseresult as completed data and replaced the last confirmed page. Desktop cancellation resolved as success without republishing that confirmed page, leaving an optimistic page number beside old rows. This change keeps a confirmed result in the paging state, rejects failed Web/Desktop results through the existing error path, and republishes a clean confirmed clone on cancellation.Affected surfaces
Verification
Risk and compatibility
Reviewer map
viewTablePagingModel.reduceViewTablePagingEvent, thenuseViewTablePaging.executePage.d5aac0924f22cc422e25272dc2530ac97b05ea36; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.
Latest-main revalidation (2026-09-04)