Skip to content

fix(client): settle table paging cancellation and errors - #2827

Open
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/view-table-paging-settlement
Open

HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/view-table-paging-settlement

Conversation

@HandSonic

@HandSonic HandSonic commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Related issue

N/A - no matching issue was found.

Summary

Table-browser paging treated a success=false result as completed data and replaced the last confirmed page. Desktop cancellation resolved as success without republishing that confirmed page, leaving an optimistic page number beside old rows. This change keeps a confirmed result in the paging state, rejects failed Web/Desktop results through the existing error path, and republishes a clean confirmed clone on cancellation.

Affected surfaces

  • Frontend / Web
  • Backend / API / Storage
  • Database plugin / Driver
  • JCEF / Desktop packaging
  • CI / Build / Release
  • Documentation only

Verification

  • Commands and results:
    • Red result-pagination suite: 10 passed / 2 failed on current main.
    • Fixed result-pagination suite: 12 passed.
    • Related result-set, status, SQL request-tracker, stream, and execution-log contracts: passed.
    • Targeted ESLint: passed.
    • Full Community prebuild, Umi/Webpack build, and production bundle verifier: passed.
    • Fork code and CodeQL checks: passed.
  • Manual verification: N/A - pure reducer and deferred stream tests cover failure and cancellation settlement.
  • UI evidence: N/A

Risk and compatibility

  • Public API or stored data: No API or persisted-state changes.
  • Database or driver compatibility: N/A.
  • Network, privacy, or security: N/A.
  • Community / Local / Pro boundary: Shared Community table-browser paging.
  • Backward compatibility: Successful page responses preserve current normalization and result identity behavior.

Reviewer map

  • Start here: viewTablePagingModel.reduceViewTablePagingEvent, then useViewTablePaging.executePage.
  • Failure condition: a failed result replaces confirmed rows, or cancellation leaves page controls ahead of visible data.
  • Rollback or disable path: Revert commit d5aac0924f22cc422e25272dc2530ac97b05ea36; no migration is required.

Contributor declaration

  • I linked the Issue that defines this change.
  • I tested the affected behavior and reported the actual results above.
  • I did not include credentials, private data, or generated build output.
  • I disclosed substantial AI assistance below, or this PR contains no substantial AI-generated code.

AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.

Latest-main revalidation (2026-09-04)

  • Rebased onto upstream 144a04e; current head d5aac09.
  • Table paging flow and related pagination suite: 12/12 passed; targeted ESLint passed.
  • Included in the green combined Community production build and bundle verification.

@HandSonic
HandSonic requested review from a team, Aias00 and openai0229 as code owners August 30, 2026 17:48
@openai0229 openai0229 moved this to In Review in Chat2DB Community Aug 30, 2026
@HandSonic
HandSonic force-pushed the fix/view-table-paging-settlement branch from f9d6e59 to 262fa60 Compare September 3, 2026 08:35
@HandSonic
HandSonic force-pushed the fix/view-table-paging-settlement branch from 262fa60 to d5aac09 Compare September 3, 2026 21:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants