Conversation
Normalize quoted Windows PATH entries and skip entries that still cannot be parsed so shell capability detection remains available. Add regression coverage for issue #2892.
auenger
force-pushed
the
fix/windows-shell-path-2892
branch
from
September 11, 2026 09:17
9fa143d to
7c0de20
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATHtokens before resolving installed shellsInvalidPathExceptioninstead of failing the entire terminal-capabilities requestFixes #2892
Verification
TerminalSessionManagerTest#findsCommandInQuotedPathEntries+skipsInvalidPathEntriesWhenFindingCommand— 2 tests, 0 failures, 0 errorsTerminalSessionManagerTeston the latestmain— 18 tests, 0 failures, 0 errors, 1 platform-specific skipgit diff --check— passedWindows desktop runtime verification remains CI/platform-only because the local verification host is macOS.