[WIP] Pdok 18835/vervanging trex#40
Draft
DvBree wants to merge 5 commits into
Draft
Conversation
kad-korpem
approved these changes
Jun 24, 2026
kad-korpem
left a comment
kad-korpem
left a comment
Collaborator
There was a problem hiding this comment.
Nog even naar de linting errors kijken (vooral code style en type safety dingetjes zo te zien)
DvBree
force-pushed
the
PDOK-18835/vervanging-trex
branch
from
June 29, 2026 08:31
a6e3eb6 to
153afac
Compare
RoelvandenBerg
requested changes
Jul 3, 2026
RoelvandenBerg
left a comment
RoelvandenBerg
left a comment
Contributor
There was a problem hiding this comment.
Nice! Klein dingetje.
Had je de go styleguide al gelezen? Zo nee dan is dat een goeie om te doen.
| return quadrantI & right | ||
| // A version of Amanatides-Woo | ||
| // Concept: parametrize line with parameter t, with t = 0 being the start and t = 1 the endpoint. Then compute the t for which tile boundaries are intersected. By taking a suitable multiple of t, this is guaranteed to be integral. Use these to raycast along the tiles. | ||
| func (ix *PointIndex) AmanatidesWoo(line geom.Line, l Level, ringIdx int, pointIdx int) { |
Contributor
There was a problem hiding this comment.
Ik stel voor deze CellTraversal te noemen oid. (geen FastCellTraversal (dat was mijn eerste voorstel obv AmantidesWoo) want dat is een finalBattleMostDangerousBossMonster, via)
Contributor
There was a problem hiding this comment.
Ben je van plan deze buiten de pointindex / dit package te gebruiken? CamelCase is voor exported identifiers, pascalCase voor de rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a work in progress on tile generation within
texel. This feature is not yet finished. Now implemented is:Type of change
Checklist: