Skip to content

Conversation

@CSWYF3634076
Copy link
Collaborator

@CSWYF3634076 CSWYF3634076 commented Feb 3, 2026

Motivation

当前启动时如果worker启动失败,apiserver&engine不会退出。具体原因是会一直在while self.get_profile_block_num_signal.value[0] == 0:等待,但是因为worker已经挂了,永远拿不到

If the worker fails to start during the current startup process, the apiserver&engine will not exit. The specific reason is that it will keep waiting in the loop while self.get_profile_block_num_signal.value[0] == 0:, but since the worker has already crashed, it will never receive the signal

Modifications

增加判断worker进程是否存在

Add a check to determine whether the worker process exists

Usage or Command

no

Accuracy Tests

no

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Feb 3, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@6563b83). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/engine/common_engine.py 0.00% 1 Missing and 2 partials ⚠️
fastdeploy/engine/engine.py 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6322   +/-   ##
==========================================
  Coverage           ?   66.62%           
==========================================
  Files              ?      385           
  Lines              ?    51228           
  Branches           ?     7991           
==========================================
  Hits               ?    34131           
  Misses             ?    14642           
  Partials           ?     2455           
Flag Coverage Δ
GPU 66.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants