fix(xray): synchronize process status checks - #86
Open
dr-hoseyn wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dr-hoseyn
marked this pull request as ready for review
September 3, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core.Startedreadsexec.Cmd.ProcessStatewhileCmd.Waitwrites it, and it reads the process pointer while lifecycle methods replace it. Health checks and API status requests can therefore race with process exit, stop, or restart.This change protects process status checks with the core mutex and uses the existing
waitDonechannel to observe process exit instead of readingProcessState.StartandStopcall a lock-held helper so they do not recursively acquire the mutex. Regression tests use a real child process to cover exit, concurrent polling during stop/replacement, and duplicate-start rejection without requiring an installed Xray binary.Validation:
go test ./backend/xray -run '^TestCoreStarted' -count=25 -timeout=180s— passedgo vet ./backend/xray— passedgit diff --check— passed/usr/local/bin/xrayis unavailable on this Windows host.-raceexecution is unavailable because this host has no C compiler. The PR adds a focused Linux CI race check; GitHub currently marks the fork workflow asaction_required, pending maintainer approval.