fix(dashboard): copy configs on insecure contexts - #805
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. Walkthrough
ChangesSubscription configuration copying
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized fix routes configuration copying through the shared clipboard fallback and only reports success after the operation succeeds. No actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Fixes #704
Type of change
Checklist
Testing
ESLint could not start in this checkout because
eslint.config.jsimports@eslint/js, which is not present in the installed dependencies. TypeScript and the full production build both passed.Screenshots
Not applicable; this changes clipboard behavior without altering the UI.
Notes for reviewers
The subscription modal bypassed the existing
useClipboardhelper and callednavigator.clipboard.writeTextdirectly. Browsers restrict that API to secure contexts, so locally hosted panels opened over plain HTTP could generate valid configurations and QR codes while leaving the clipboard empty. Both single-config and Copy All actions now use the existing helper, including itsexecCommandfallback.Summary by CodeRabbit