fix: ECH for mihomo and sing-box - #806
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
If the ech is a base-64 encoded config, there is no problem. But if we choose to use the other supported format by Xray (eg, "example.com+https://1.1.1.1/dns-query"), then Sing-box and Mihomo will not be able to start the profile and proxies at all. |
Summary
FYI: This is AI-written code
We've had ECH for Xray, but not for mihomo, and the implementation for Sing-Box was imperfect and unusable.
This PR fixes the ECH issue for both subscription formats.
Type of change
Checklist
Testing
I have tested it on both formats, and they work with no issues as far as I can see.
Screenshots
Notes for reviewers