fix(singbox): handle unsafe uTLS fingerprint - #813
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughSing-box TLS generation now normalizes the ChangesSing-box TLS handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change prevents invalid uTLS fingerprints in generated sing-box profiles while preserving native TLS behavior and using a supported Reality fallback; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Remove the tests and dont add a check for reality if it set to unsafe use chrome also update clash config if require |
|
@ImMohammad20000 Done in b1b0a26:
Existing subscription tests pass ( |
Summary
unsafefingerprint withchromein every sing-box TLS profile.unsafetochromefor Clash Meta/Mihomo proxy and xHTTP download fingerprints as well.Fixes #808
Type of change
Checklist
Testing
A direct generator check also confirmed that
unsaferenders aschromein sing-box, Clash Meta, and Mihomo xHTTP download settings.Screenshots
Not applicable; backend subscription generation only.
Notes for reviewers
Both sing-box and Mihomo reject or do not support Xray's
unsafeuTLS fingerprint. The generated client configurations now use the supportedchromefingerprint consistently, without changing the stored host setting used by Xray.