Skip to content

[Minor] Add global default values for some tags#2165

Open
Coronia wants to merge 15 commits into
Phobos-developers:developfrom
Coronia:global-tag
Open

[Minor] Add global default values for some tags#2165
Coronia wants to merge 15 commits into
Phobos-developers:developfrom
Coronia:global-tag

Conversation

@Coronia
Copy link
Copy Markdown
Contributor

@Coronia Coronia commented Apr 7, 2026

If there's other tag that is worth globalizing please let me know

@Coronia Coronia added Minor Minor feature and/or fix, not a lot of changes or they are not significant ⚙️T1 T1 maintainer review is sufficient No Documentation Needed No documentation needed whatsoever No test needed This PR is simple enough, or changes no in-game logic, so no in-game testing is required. labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl
Copy link
Copy Markdown
Contributor

TaranDahl commented Apr 7, 2026

Arcing.AllowElevationInaccuracy.
CanBeBuiltOn and IsPassable for TerrainTypes. This needs a smart default, smart to true for non-Tiber tree.
Splits.UseWeaponTargeting, AirburstWeapon.ApplyFirepowerMult
Shrapnel.AffectsGround, Shrapnel.AffectsBuildings, Shrapnel.UseWeaponTargeting

TaranDahl
TaranDahl approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@TaranDahl TaranDahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to wait for a longer period of time and take into account more users' opinions.

DeathFishAtEase

This comment was marked as duplicate.

Sign in to view

DeathFishAtEase
DeathFishAtEase reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@DeathFishAtEase DeathFishAtEase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repetitive content

Comment thread docs/New-or-Enhanced-Logics.md Outdated
@phoboscn-bot
Copy link
Copy Markdown

phoboscn-bot commented Apr 13, 2026

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/355/1

@TaranDahl
Copy link
Copy Markdown
Contributor

TaranDahl commented Apr 21, 2026

OpenTopped.IgnoreRangefinding
OpenTopped.AllowFiringIfDeactivated
OpenTopped.ShareTransportTarget

@DeathFishAtEase
Copy link
Copy Markdown
Collaborator

DeathFishAtEase commented Apr 21, 2026

OpenTopped.IgnoreRangefinding  OpenTopped.AllowFiringIfDeactivated  OpenTopped.ShareTransportTarget

They seem to have been processed in 0d7ac01? See src/Ext/Rules/Body.cpp.

DeathFishAtEase and others added 8 commits April 21, 2026 20:37
@DeathFishAtEase
DecloakDamagedTargets
301bb72
@DeathFishAtEase
Sinkable, SinkSpeed, and Sinkable.SquidGrab
ee84424
@DeathFishAtEase
update
4c6abb7
@DeathFishAtEase
Remove the changes made by this PR to Hooks.UI.cpp
ef90125 
Due to duplication with existing content in `develop` branch
@Coronia
Merge branch 'global-tag' of https://github.com/Coronia/Phobos into g…
3a20d7d 
…lobal-tag

# Conflicts:
#	src/Ext/Rules/Body.cpp
#	src/Ext/Rules/Body.h
@Coronia
Merge branch 'develop' into global-tag
eaf5587 
# Conflicts:
#	docs/New-or-Enhanced-Logics.md
#	src/Ext/Bullet/Hooks.cpp
#	src/Ext/Techno/Hooks.Firing.cpp
#	src/Ext/TerrainType/Hooks.Passable.cpp
@Coronia
fix
6ddbb4d
@Coronia
Vertical.AircraftFix
72e17db
@DeathFishAtEase
Copy link
Copy Markdown
Collaborator

DeathFishAtEase commented Jun 2, 2026

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

https://www.phoboscn.top/t/topic/355/1

@Coronia You can check the discussions in this topic to avoid overlooking some requirements.
There is some controversy over the handling of wake animation (although we are not unable to decide to use different default value retrieval rules through a certain bool, that would be too stupid and still unable to meet users' various strange requirements).

@DeathFishAtEase
Restore the documentation of [General] -> Interceptable
285e477 
This was overwritten in a previous merge, but it just corrects an earlier line error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeathFishAtEase DeathFishAtEase DeathFishAtEase left review comments

@TaranDahl TaranDahl TaranDahl approved these changes

Assignees

No one assigned

Labels

Minor Minor feature and/or fix, not a lot of changes or they are not significant No Documentation Needed No documentation needed whatsoever No test needed This PR is simple enough, or changes no in-game logic, so no in-game testing is required. ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Coronia @TaranDahl @phoboscn-bot @DeathFishAtEase