Skip to content

Allow infantry to perform type conversion when deploying and undeploying#2239

Merged
Coronia merged 5 commits into
Phobos-developers:developfrom
DeathFishAtEase:Convert.(Un)deploy
Jun 6, 2026
Merged

Allow infantry to perform type conversion when deploying and undeploying#2239
Coronia merged 5 commits into
Phobos-developers:developfrom
DeathFishAtEase:Convert.(Un)deploy

Conversation

@DeathFishAtEase
Copy link
Copy Markdown
Collaborator

@DeathFishAtEase DeathFishAtEase commented Jun 3, 2026 •
edited
Loading

Now infantry can perform type conversion when executing the Deploy and Undeploy sequences.

Convert (Un)deploy

E1↔GGI, YURI↔YURIPR, E2→BORIS

In rulesmd.ini:

[SOMEINFANTRY]             ; InfantryType
Convert.Deploy=            ; InfantryType
Convert.Undeploy=          ; InfantryType

Note

For the sake of logical clarity, this feature does not allow the converted unit to trigger another conversion before the current sequence ends. If continuous conversion is needed, please use Convert.Land/Water.

@DeathFishAtEase DeathFishAtEase added Tested ⚙️T1 T1 maintainer review is sufficient No Documentation Needed No documentation needed whatsoever labels Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot
Copy link
Copy Markdown

phoboscn-bot commented Jun 3, 2026

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/545/1

TaranDahl
TaranDahl requested changes Jun 3, 2026
View reviewed changes
Comment thread src/Ext/Techno/Hooks.cpp Outdated
@DeathFishAtEase DeathFishAtEase self-assigned this Jun 6, 2026
@Coronia Coronia added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Jun 6, 2026
@Coronia Coronia merged commit 5d5ae32 into Phobos-developers:develop Jun 6, 2026
7 checks passed
@DeathFishAtEase DeathFishAtEase deleted the Convert.(Un)deploy branch June 6, 2026 13:34
Coronia added a commit that referenced this pull request Jun 6, 2026
@Coronia
Temporary revert "Allow infantry to perform type conversion when depl…
e4b9acf 
…oying and undeploying (#2239)"

This reverts commit 5d5ae32.

The current implementation will bring performance cost according to the profiler. We'll have to find a way to improve it in the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Starkku Starkku Starkku left review comments

@NetsuNegi NetsuNegi NetsuNegi approved these changes

@TaranDahl TaranDahl TaranDahl approved these changes

Assignees

@DeathFishAtEase DeathFishAtEase

Labels

No Documentation Needed No documentation needed whatsoever ⚙️T1 T1 maintainer review is sufficient Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DeathFishAtEase @phoboscn-bot @Starkku @NetsuNegi @TaranDahl @Coronia