SystemUI: Partially revert 718d6d6

[rayavanindra]

• Optimize split notification layout for regular screen

Summary by CodeRabbit

• Refactor
  • Streamlined margin handling in the system user interface for improved layout consistency.

[coderabbitai]

Walkthrough

The modifications in the WindowRootView.kt file involve a notable simplification of the margin handling logic within the WindowRootView. Specifically, the update removes the ignoreLeftInset property from LayoutParams and refines the process for adjusting margins in light of the ignoreRightInset property. This change aims to make the management of margins more straightforward and efficient, enhancing the overall functionality and readability of the codebase.

Changes

File Path	Summary
.../systemui/scene/ui/view/WindowRootView.kt	Removed ignoreLeftInset from LayoutParams and simplified margin handling logic related to ignoreRightInset.

🐇✨
In the realm of code, where logic threads weave,
A rabbit hopped in, with changes up its sleeve.
"No more left inset," it cheerfully declared,
Simplifying margins, with no effort spared.
So here's to the code, now sleek and refined,
A testament to the rabbit's ingenious mind.
🌟📐

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8c40a52 and a0fdda6.

Files ignored due to path filters (4)

• packages/SystemUI/res/layout/super_notification_shade.xml is excluded by: !**/*.xml
• packages/SystemUI/res/values-land/dimens.xml is excluded by: !**/*.xml
• packages/SystemUI/res/values-sw600dp-land/dimens.xml is excluded by: !**/*.xml
• packages/SystemUI/res/values/attrs.xml is excluded by: !**/*.xml

Files selected for processing (1)

• packages/SystemUI/src/com/android/systemui/scene/ui/view/WindowRootView.kt (3 hunks)

Additional comments: 1

packages/SystemUI/src/com/android/systemui/scene/ui/view/WindowRootView.kt (1)

• 104-108: The logic for updating margins based on ignoreRightInset has been simplified, which is a positive change for improving the layout's performance and appearance on standard-sized screens. However, it's important to ensure that this change does not inadvertently affect layouts that might rely on the previous behavior of ignoreRightInset. Specifically, the removal of ignoreLeftInset and the simplification here could lead to different margin behaviors that were not intended or tested.

Consider adding unit tests or UI tests to verify that the changes in margin handling do not negatively impact the layout of notifications or other UI elements within the WindowRootView. This could involve testing with various screen sizes and configurations to ensure compatibility and the desired improvements in layout performance and appearance.

Additionally, verify that the removal of ignoreLeftInset and the changes to ignoreRightInset handling are well-documented in the project's documentation or comments, to aid future developers in understanding the rationale behind these changes and how they should work with the updated LayoutParams.