Add more bugprone-* clang-tidy checks, Part B #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawme
force-pushed
the
norm.evangelista/add-further-bugprone-checks-part-b
branch
from
6e0167f to
c26c4c6
Compare
larshg
reviewed
Jan 17, 2026
| centroid[1] + (0.5f * model[1]), | ||
| centroid[2] + (0.5f * model[2])); | ||
| sprintf(name, "normal_%d", unsigned(i)); | ||
| sprintf(name, "normal_%d", static_cast<unsigned>(i)); |
Contributor
There was a problem hiding this comment.
Suggested change
| sprintf(name, "normal_%d", static_cast<unsigned>(i)); | |
| sprintf(name, "normal_%d", static_cast<unsigned int>(i)); |
larshg
reviewed
Jan 17, 2026
| char name[1024]; | ||
| for (std::size_t i = 0; i < prev_models_size; i++) { | ||
| sprintf(name, "normal_%d", unsigned(i)); | ||
| sprintf(name, "normal_%d", static_cast<unsigned>(i)); |
Contributor
There was a problem hiding this comment.
`
Suggested change
| sprintf(name, "normal_%d", static_cast<unsigned>(i)); | |
| sprintf(name, "normal_%d", static_cast<unsigned int>(i)); |
larshg
reviewed
Jan 17, 2026
| typename EdgeAwarePlaneComparator<PointT, Normal>::Ptr plane_comparator_; | ||
| PointIndices::Ptr plane_indices_; | ||
| unsigned char* rgb_data_; | ||
| unsigned char* rgb_data_{}; |
Contributor
There was a problem hiding this comment.
Suggested change
| unsigned char* rgb_data_{}; | |
| unsigned char* rgb_data_{nullptr}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate #6368, Part B including
appschanges to manage the size of the PR.Add 4 additional bugprone clang-tidy checks and applied fixes
bugprone-assert-side-effectbugprone-dangling-handlebugprone-forward-declaration-namespacebugprone-inaccurate-eraseSummary
These checks improve code safety and correctness by: