fix MC-53850#61
Closed
MicrocontrollersDev wants to merge 4 commits intoPolyfrost:mainfrom
Closed
Conversation
Member
|
just remove the other check other than remote |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
!! this changes vanilla behavior
mojira: https://bugs.mojang.com/browse/MC-53850
forge: MinecraftForge/MinecraftForge#3807
this is fixed in forge 1.11+ so i dont think itd be a problem in 1.8 even though its not a fully client sided fix. it was a very simple backport though so thought id pr it regardless
Related Issue(s)
Fixes #
How to test
item command for 1.8.9: /summon Item ~2 ~ ~ {Item:{id:stone,Count:1},Invulnerable:1}
xp command for 1.8.9: /summon Item ~2 ~ ~ {Item:{id:stone,Count:1},Invulnerable:1}
you can tell its not vanilla as without the fix, setting the xp orb on fire will make the armor stand stop in place until you are close enough to collect it, meanwhile with the fix the armor stand will continue to slowly follow you around even while on/after the fire. since its fixed in forge i dont think its an issue here
Release Notes
Documentation