Skip to content

feat(tasks): route local skill tags through the cloud prompt pipeline#2925

Open
tatoalo wants to merge 1 commit into
local-skill-03-agent-installfrom
local-skill-04-core-plumbing
Open

feat(tasks): route local skill tags through the cloud prompt pipeline#2925
tatoalo wants to merge 1 commit into
local-skill-03-agent-installfrom
local-skill-04-core-plumbing

Conversation

@tatoalo

@tatoalo tatoalo commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Problem

for cloud tasks, local skill invocations only sent the slash command text. User-local and repo-local skills were available in the local editor but not in the cloud sandbox

Changes

  • let's bundle uploadable local skills into zip artifacts with SHA-256 metadata and send them through the existing cloud artifact upload flow.

  • install skill_bundle artifacts in the agent server before prompt delivery, inject the bundled skill instructions for the invoked turn, and suppress the raw slash command from the model-facing prompt so local skills behave like actual skills rather than unsupported commands

  • refresh slash command metadata when a follow-up command is submitted, so newly created local skills can be selected and invoked without starting a brand-new task.

closes #2260

tatoalo commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 8422a11.

@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "feat(tasks): route local skill tags thro..." | Re-trigger Greptile

Comment thread packages/core/src/message-editor/skillTags.ts Outdated
Comment thread packages/core/src/editor/cloud-prompt.ts
@tatoalo tatoalo force-pushed the local-skill-03-agent-install branch from dbe89f8 to bcbc926 Compare June 25, 2026 09:48
@tatoalo tatoalo force-pushed the local-skill-04-core-plumbing branch from 753b5a5 to c120794 Compare June 25, 2026 09:48
@tatoalo tatoalo force-pushed the local-skill-04-core-plumbing branch from c120794 to 8422a11 Compare June 25, 2026 09:58
@tatoalo tatoalo self-assigned this Jun 25, 2026
@tatoalo tatoalo requested a review from a team June 25, 2026 10:41
@tatoalo tatoalo marked this pull request as ready for review June 25, 2026 10:41
@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff (1)

  1. packages/core/src/sessions/sessionService.ts, line 2507-2511 (link)

    P1 Double-resolve of skill command prompt on terminal-status path

    sendCloudPrompt resolves the prompt via resolveCloudPrompt before calling resumeCloudRun (line ~2253: return this.resumeCloudRun(session, normalizedPrompt)), and resumeCloudRun then calls resolveCloudPrompt again on the already-resolved prompt. If resolveLocalSkillCommandPrompt performs any side effects — reading local skill files, packaging archives, or making network calls — those operations execute twice. A concrete failure scenario: skill bundle artifacts could be uploaded twice, or file handles left open by the first pass could conflict with the second.

    Either remove resolveCloudPrompt from resumeCloudRun (since sendCloudPrompt is currently its only caller and already hands it a normalized prompt), or pass the raw prompt to resumeCloudRun from sendCloudPrompt and keep resolution inside resumeCloudRun exclusively.

Reviews (2): Last reviewed commit: "feat(tasks): route local skill tags thro..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant