fix(agent-server): handle follow-up turn failures and classify timeouts#2938
Merged
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(agent-server): handle follow-up turn..." | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "fix(agent-server): scope recoverable to ..." | Re-trigger Greptile |
There was a problem hiding this comment.
Focused, well-tested fix: adds timeout error classification, refactors failure handling to distinguish recoverable upstream errors in follow-up turns, and properly scopes recoverability to interactive mode only. No showstoppers; the one bot review comment was addressed and resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an agent turn crashed mid-prompt on a live follow-up message, the failure was effectively invisible:
user_messagehad no failure handling (unlike the initial/resume paths), so a thrown agent error just returned as an HTTP-200 JSON-RPC error"API Error: ... timed out"was classified as a permanentagent_errorrather than a transient upstream stall, so even retryable timeouts were treated as hard failuresChanges
upstream_timeoutclassificationhandleTurnFailure(payload, phase, error)used by the initial, resume, and (newly wired) follow-up pathserrorsession update instead of riding the normal assistant-message path.before:
after: