fix(command-center): prevent scroll on grid cell focus#2956
Open
K3N4Y wants to merge 1 commit into
Open
Conversation
Calling .focus() without preventScroll caused the page to scroll to the top when clicking a command center grid cell.
Contributor
|
Reviews (1): Last reviewed commit: "fix(command-center): prevent scroll on g..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When clicking a command center grid cell, the browser scrolls the page to bring the newly-focused element into view. This is the default behavior of
.focus()— it scrolls the focused element into the visible viewport, which jumps the user away from where they were.Changes
Added
{ preventScroll: true }to the.focus()call inCommandCenterGrid.tsx:84-85. This tells the browser to focus the element without scrolling, matching the intent of the click handler (which delegates focus to an interactive element inside the cell without moving the viewport).How did you test this?
tsc --noEmitcleanbiome checkcleanvitest run— 116 files, 1018 tests (UI), 179 files, 1755 tests (core), all passingAutomatic notifications