feat(warehouse): hand over a pre-filled link per detected source - #1087
Open
Gilbert09 wants to merge 1 commit into
Open
feat(warehouse): hand over a pre-filled link per detected source#1087Gilbert09 wants to merge 1 commit into
Gilbert09 wants to merge 1 commit into
Conversation
The outro named the sources it found and told the user to start a second CLI run to connect them. Every run with a detected source now gets a link straight to that source's form in the app instead, so connecting one is a click. This reaches every run that detects a source, not only the runs the orchestrator offers the warehouse task to. Also fix the Stripe tip's URL. A '/project/' segment with no team id matches no route, so that link rendered the 404 scene.
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A user finishes the install wizard, is told their project has a Postgres and a Stripe to connect, and the only route offered is starting a second CLI run. Most never do: of the people who saw that suggestion, 3.7% went on to run
npx @posthog/wizard warehouse.Import it into the data warehouse with: npx @posthog/wizard warehouse.Separately, the Stripe tip shown during the agent run links to a URL that 404s.
Changes
<appHost>/project/<id>/data-warehouse/new-source?kind=<kind>.npx @posthog/wizard warehouseline for connecting everything in one pass.LinkText, so a URL becomes an OSC 8 hyperlink and its label is shortened rather than wrapped across lines.https://app.posthog.com/project/data-warehouse/new-source?kind=Stripehas a/project/segment with no team id, which matches no route and renders the 404 scene.kindis matched case-insensitively by the app, and a kind it cannot resolve falls back to the source catalog rather than erroring, so a source we detect before the app ships a connector still lands somewhere useful.Test plan
warehouse-suggestion.test.ts: the link carries the project segment and the source kind, and a 5-source project yields 3 links plus a summary line. The existing test asserted the joined label list, which no longer describes the output.splitPromptIntoSegments. It splits intoConnect Postgres:plus the URL, which is what puts the address on its own line with the full target preserved.LLM context
I (actually Claude Opus 5) wrote this while looking for the reason the warehouse flow converts poorly. The in-run task reaches only the share of runs the orchestrator serves, so the outro is where the remaining runs can be reached.