Open
Conversation
COMI-1240/unzip-everything
COMI-1240/unzip-everything
COMI-1240/unzip-everything
COMI-1240/unzip-everything
COMI-1240/unzip-everything
See https://stackoverflow.com/questions/22745076 COMI-1240/unzip-everything
COMI-1240/unzip-everything
COMI-1240/unzip-everything
Author
|
@ProfessorBurke I think I'm done optimizing the PNG assets. I fixed the sRGB color profile in all directories by executing this shell one-liner: I also corrected colors and alpha transparency as needed for some of the images in Chapter 1. I just have one question left about those images: I am using And I guess one other question: Do you want me to zip everything back up in this branch before you merge it back in? (It's much easier for you to approve the code review if you can see the differences, although in this case the changes are mostly in binary files.) |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Clone the code examples and extract the zipped archives for easier version control.
Also, rename the chapter directories so they'll list in properly sorted order.
Finally, optimize PNG files to correct colors and suppress
libpngwarnings.