Skip to content

fix: stabilize blackbox tests#205

Merged
LKaemmerling merged 1 commit into
PromPHP:mainfrom
simPod:fix-blackbox-apc-502
May 28, 2026
Merged

fix: stabilize blackbox tests#205
LKaemmerling merged 1 commit into
PromPHP:mainfrom
simPod:fix-blackbox-apc-502

Conversation

@simPod

@simPod simPod commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Configure PHP-FPM to listen on port 9000 on all container interfaces
  • Fix BlackBox nginx 502 responses caused by nginx connecting to php-fpm:9000 while FPM only listened on loopback inside its own container
  • Reserve APCng summary observation indexes with the atomic apcu_inc() return value to avoid losing concurrent observations

Verification

  • docker compose up -d --build
  • docker compose run --rm phpunit env ADAPTER=apc vendor/bin/phpunit --filter gaugesShouldBeOverwritten tests/Test/BlackBoxTest.php
  • docker compose run --rm phpunit env ADAPTER=apc vendor/bin/phpunit tests/Test/BlackBoxTest.php
  • docker compose run --rm phpunit env ADAPTER=apcng vendor/bin/phpunit tests/Test/BlackBoxTest.php

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Configures the PHP-FPM container to accept FastCGI connections from other containers (not just loopback), resolving Nginx-to-PHP-FPM connectivity issues that previously manifested as 502s in the blackbox Nginx setup.

Changes:

  • Updated PHP-FPM pool config to listen on TCP port 9000 on the container’s interfaces rather than 127.0.0.1:9000.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@simPod simPod changed the title fix: expose php-fpm to blackbox nginx fix: stabilize blackbox tests May 28, 2026
@simPod simPod force-pushed the fix-blackbox-apc-502 branch from 2e25472 to e3a3e7b Compare May 28, 2026 07:28
Signed-off-by: Simon Podlipsky <simon@podlipsky.net>
@simPod simPod force-pushed the fix-blackbox-apc-502 branch from e3a3e7b to 665e47a Compare May 28, 2026 07:33

@LKaemmerling LKaemmerling left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LKaemmerling LKaemmerling merged commit 6007cda into PromPHP:main May 28, 2026
20 checks passed
@simPod simPod deleted the fix-blackbox-apc-502 branch May 28, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants