Added feature: exposing prometheus metrics#153
Open
ahpooch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a solution to #152
It is a tested and working as expected code though written with AI support.
Based on the changes provided in this PR, I was able to build custom Docker image that exposes Prometheus metrics as proposed. After that I managed to create Grafana Dashboard for monitoring py-kms container metrics, and it looks solid (after 26 iterations of building image while working on this solution using AI and my humble programming skills).
The last image build from PR code is available here if somebody wants to test it:
https://hub.docker.com/repository/docker/ahpooch/py-kms/tags/prometheus-metrics26/sha256-f0b8449bdab21fb6491b5e5f3d0b209d96f9e09ba1b7bcb9004476b64193e259
Or you could build the Docker image yourself from the code of this PR after reading the changes it proproses to project.