Conversation
OpaqueContainer keyed its entries on id(v), so one object attached to two frames produced a single entry shared by both buffers. Freeing either frame ran key_free, which popped that entry, and the other frame's opaque silently became None. Worse, once the object was released, a later object could land on the same address and be handed back through the stale key. Hand out a fresh uint64 per add() instead. Every buffer then owns its entry, holders are independent, and the object is released once the last one goes away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpaqueContainer keyed its entries on id(v), so one object attached to two frames produced a single entry shared by both buffers. Freeing either frame ran key_free, which popped that entry, and the other frame's opaque silently became None. Worse, once the object was released, a later object could land on the same address and be handed back through the stale key.
Hand out a fresh uint64 per add() instead. Every buffer then owns its entry, holders are independent, and the object is released once the last one goes away.