Fix typo in scaling of PyROS separation objectives#3817
Merged
mrmundt merged 6 commits intoPyomo:mainfrom Jan 19, 2026
Merged
Conversation
jsiirola
approved these changes
Jan 16, 2026
jsiirola
approved these changes
Jan 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3817 +/- ##
=======================================
Coverage 89.43% 89.44%
=======================================
Files 906 906
Lines 105444 105445 +1
=======================================
+ Hits 94303 94312 +9
+ Misses 11141 11133 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrmundt
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
The changes to the implementation of the second-stage inequality constraints in PyROS as of #3341 were not accounted for in the scaling of the separation problem objectives. In particular, as of #3341, though these inequalities are allowed to have nonzero right-hand sides, the nonzero right-hand sides of the inequalities are not accounted for when calculating the scaling factors. This affects the implementation of the PyROS relative robust feasibility tolerance and heuristic for selecting the uncertain parameter realization for the subproblems of the next iteration. The present PR corrects the oversight and adds an accompanying test.
Changes proposed in this PR:
See summary/motivation.
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: