fix(qwik-router): ErrorBoundary catches its own subtree (closest-parent)#8744
Open
maiieul wants to merge 2 commits into
Open
fix(qwik-router): ErrorBoundary catches its own subtree (closest-parent)#8744maiieul wants to merge 2 commits into
maiieul wants to merge 2 commits into
Conversation
The container now routes async errors (qerror) to the nearest ErrorBoundary via handleError, like synchronous render throws already do. Drops the global qerror broadcast where every boundary caught every error. BREAKING CHANGE: <ErrorBoundary> no longer reacts to every error on the page.
🦋 Changeset detectedLatest commit: 075d8fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
A component throwing during SSR render is now routed to the closest ErrorBoundary (matching the client) and its fallback is rendered in place, instead of aborting to the error page. Only boundaries that expose a fallback (`<ErrorBoundary fallback$>` sets `store.$fallback$`) are caught — SSR can't re-render the boundary — so boundaries without one keep propagating, unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container now routes async errors (qerror) to the nearest ErrorBoundary via handleError, like synchronous render throws already do. Drops the global qerror broadcast where every boundary caught every error.
BREAKING CHANGE: no longer reacts to every error on the page.
What is it?
Description
Checklist
pnpm change