3d array compatibility#25
Draft
PinkShnack wants to merge 5 commits into
Draft
Conversation
Member
|
Please remove draft state to indicate that it is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #23, I want to make
nrefocus3d array compatible as I did with qpretrieve.Here it is a little smarter, and "less" of a breaking change compared to
qpretrieve. The return shape will simply be the same as the input array shape. Which makes logical sense and is just an extension of the current options of 1D and 2D inputs. It's something to think about regarding the previous breaking change inqpretrieve; we could make the array handling similar to this.todos