Skip to content

Fix eliminate_contiugous iterator bug #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
causten merged 6 commits into from
Feb 24, 2026
Merged

Fix eliminate_contiugous iterator bug #4589

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
461abd8
Make reshape_lazy assert into a exception. Eliminate_contiugous iterator
CharlieL7 Feb 3, 2026
cb0103a
Revert to assert for bytes mismatch
CharlieL7 Feb 10, 2026
d226f8c
Merge branch 'develop' into elim_cont_reshape_lazy_fix
CharlieL7 Feb 10, 2026
780df06
Merge branch 'develop' of github.com:ROCm/AMDMIGraphX into elim_cont_…
CharlieL7 Feb 18, 2026
dd439df
licensing
CharlieL7 Feb 18, 2026
c869cce
Add guard to make sure arg still in inputs
CharlieL7 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/eliminate_contiguous.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved.
* Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -135,8 +135,11 @@ static void remove_contiguous(const std::string& op_name, module& m, F f)
auto args = ins->inputs();
auto mod_args = ins->module_inputs();

for(auto arg : ins->inputs())
for(auto arg : args)
Comment thread
CharlieL7 marked this conversation as resolved.
{
Comment thread
CharlieL7 marked this conversation as resolved.
// check that arg is still in ins->inputs()
if(not contains(ins->inputs(), arg))
continue;
if(arg->name() != op_name)
continue;
if(enabled(MIGRAPHX_TRACE_ELIMINATE_CONTIGUOUS{}))
Expand Down
Loading