Open
Conversation
Added ParserExceptionBuilder class for easy construction using named parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
progresses #5952
Description of the Change
Implemented ICU4J which allows the use of named parameters in message pattern strings.
This will improve the life of translators where parameters with useful names can provide context for the phrase.
Example:
Invalid condition in {0}({1}) roll option.vs.
Invalid condition in {branchType}({condition}) roll option.Added ParserExceptionBuilder class for easier construction of error messages using named parameters.
Additionally: Fixed issue with
&replacement.&is now only removed if it is immediately followed by a alphanumeric character, and does not form part of a HTML entity. Strings like the following should render correctly:Possible Drawbacks
Having to create a map of name-value pairs can be tiresome. Thus the exception builder.
Documentation Notes
Implemented ICU4J
Release Notes
Improved context for future translation strings.
This change is