fix: move token cache to temp folder and fix locale-dependent date parsing#2
Open
paulfilkin wants to merge 3 commits intoRWS:mainfrom
Open
fix: move token cache to temp folder and fix locale-dependent date parsing#2paulfilkin wants to merge 3 commits intoRWS:mainfrom
paulfilkin wants to merge 3 commits intoRWS:mainfrom
Conversation
…rsing - Cache token file in system temp folder instead of module directory to avoid write-permission issues - Use InvariantCulture for token expiry date parsing to prevent failures on non-English locales
…lision - CommonHelper exported a function called Get-Item which shadowed the built-in Microsoft.PowerShell.Management\Get-Item cmdlet - This caused Add-SourceFiles in ProjectHelper to fail when calling Get-Item on a file path, as PowerShell resolved it to the toolkit's Get-Item (which expects -accessKey and -uri parameters) - Renamed to Get-SingleItem across all modules: CommonHelper (definition and export), ProjectHelper (1 call), ResourcesHelper (13 calls), TerminologyHelper (2 calls), UsersHelper (3 calls)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache token file in system temp folder instead of module directory to avoid write-permission issues and keep the module directory clean
Use InvariantCulture for token expiry date parsing to prevent failures on non-English locales