feat(workspace-search): Add screen reader support - #10316
Open
mikeharv wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-samples#2743
Proposed Changes
Add screen reader support to
@blockly/plugin-workspace-search:aria-labels on the input (including instructions around keyboard usage) and buttonsInitial:
After typing search term (matches found):
Pressing Enter to cycle matches:
Pressing Escape to focus matched block:
No matching blocks:
Core changes:
Role.SEARCHto Aria utils andWORKSPACE_SEARCH_*messagesTest Coverage
Unit tests cover attributes, names, and announcements.
Documentation
Updated the plugin readme to add how Escape changes focus.